I think Arcade is in place. Do we like it? Is the code where we want it? What are our longer-term plans? Skipped tests, darn it! Oh, right. There was that skipped test. In fact there are two: I don’t even remember what the other one was. Here’s the keyboard one: class TestHandlers: @pytest.mark.skip("needs revision") def test_keydown(self): fake = FakeDungeon() view = DungeonView(fake, testing=True) event = FakeEvent(pygame.K_UP) view.handle_keydown(event) assert fake.received == 'north' view.handle_keyup(event) ... I think we could do without that. I’m inclined to remove the entire file. If we need keyboard tests later, we can do new ones. I do hate to remove tests, though. It makes me feel kind of dirty somehow. Let’s make this work and then maybe let it stick around. OK< the first thing is that with Arcade, we have on_key_press and on_key_release. So let’s change those with a quick multi-cursor edit. I’m afraid to rename, lest it do something weird. In fact, PyCharm won’t rename…
No comments yet. Log in to reply on the Fediverse. Comments will appear here.