One Tiny Change

Hello, loves! A tiny article about one tiny change. Some thoughts on whether it matters. Tout le monde déteste l’IA. I haven’t looked at the code yet this morning, but if memory serves, there’s a bit of Feature Envy we might want to deal with. Let’s see: class DungeonView: def illuminate_around_dot(self): dot = self.dungeon.player_cell if not dot: return # crock to allow a test to run room = dot.room radius = 1000 if self.dungeon.dot_has('a brilliant torch') else 4 for cell in room: if cell.manhattan_distance(dot) <= radius: self.illuminate_cell(cell) def illuminate_cell(self, cell): sprite = self.keyed_sprites[cell] sprite.visible = True for content_sprite in self.keyed_sprites.content_at(cell): content_sprite.visible = True In illuminate_cell, we have two references to our KeyedSpriteList keyed_sprites, and each time we grab one or more sprites that it contains and set the sprite’s visible flag. This method, though it does refer to one of our instance variables, isn’t really about…